Add Kiro shell plugin#605
Conversation
Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds initial 1Password shell plugin support for the Kiro CLI, including API key credential wiring and corresponding provision/import coverage.
Changes:
- Introduces new
kiroplugin entrypoint with platform metadata and wiring for credentials/executables. - Adds
KIRO_API_KEYcredential type with env var provisioner and env var importer. - Adds tests covering API key provisioning and importing behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| plugins/kiro/plugin.go | Defines the Kiro plugin metadata and registers credential + executable. |
| plugins/kiro/kiro.go | Declares the Kiro CLI executable schema and its credential usage. |
| plugins/kiro/api_key.go | Implements the API key credential, docs/management links, and env var mapping. |
| plugins/kiro/api_key_test.go | Adds tests for provisioning/importing KIRO_API_KEY. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi @eddumelendez I hope to give this a review this week. |
scottisloud
left a comment
scottisloud
left a comment
There was a problem hiding this comment.
I managed to find time for a review this morning.
The KIRO_API_KEY provisioning and import path matches Kiro's documented headless auth, and the tests cover the happy path well. All good there.
One minor blocker to address called out in a comment above.
optional: Circling back to Co-Pilot's note on the token validation criteria: It looks like the prefix and other criteria matches Kiro's docs. Happy for that Co-Pilot comment to be resolved without a length criteria.
I'll take another look once that's in. Thanks again, @eddumelendez.
Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>
|
@scottisloud comment was addressed |
scottisloud
left a comment
scottisloud
left a comment
There was a problem hiding this comment.
Thanks for all the submissions and the quick turnaround on the fixes!
LGTM!
This plugin should appear in a future release of the 1Password CLI.
Overview
Adds a new Kiro shell plugin for authenticating the Kiro CLI with a Kiro API key. The plugin provisions and imports the documented
KIRO_API_KEYenvironment variable forkiro-cli.Type of change
Related Issue(s)
N/A
How To Test
To test authentication manually after initializing the plugin:
Changelog
Authenticate the Kiro CLI with API keys using 1Password Shell Plugins.